search

django / asgi_ipc

IPC-based ASGI channel layer
BSD 3-Clause "New" or "Revised" License
37 stars 13 forks source link

Various suggestions and code improvements, fixed one possible mistake #10

Closed danielniccoli closed 7 years ago

danielniccoli commented 7 years ago

Please review 5cba5c2. The two lines would have never been executed. I don't fully understand the code yet, but to me it looks like it was indented once too much.

Merge the other commits as you please.

andrewgodwin commented 7 years ago

The unindent is fine, but if you wrap things onto multiple lines can you use the form:


    x,
    y,
    z,
)```

rather than a single indented new line?
danielniccoli commented 7 years ago

Sure. But could you point to a line of code as an example? I am not 100 % sure what you mean with the single indented new line.

danielniccoli commented 7 years ago

Is this okay?

andrewgodwin commented 7 years ago

Yup, thanks!