django / asgiref

ASGI specification and utilities
https://asgi.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
1.46k stars 207 forks source link

refactor: type sync_to_async/async_to_async as returning callables instead of the SyncToAsync/AsyncToSync #396

Closed bellini666 closed 1 year ago

bellini666 commented 1 year ago

Fix #394

bellini666 commented 1 year ago

@andrewgodwin this PR is to fix the issues from https://github.com/django/asgiref/issues/394 . This is actually the way I should have typed both sync_to_async/async_to_sync to begin with.

It would be nice if this can be released as a 3.7.2 to avoid anyone else hitting that issue

andrewgodwin commented 1 year ago

Thanks - I have released this as 3.7.2 just now.