search

django / channels

Developer-friendly asynchrony for Django
https://channels.readthedocs.io
BSD 3-Clause "New" or "Revised" License
6.08k stars 800 forks source link

contributing guide: ran into an issue while installing tests #2012

Open learningboiz opened 1 year ago

learningboiz commented 1 year ago

Followed the contribution guide and faced an error when installing the tests.

Specs

Steps to reproduce

  1. Fork django/channels repo
  2. Clone repo into local machine with git clone git@github.com:your-username/channels.git
  3. Activate virtual environment
  4. Move into channels directory with cd channels
  5. Install tests with python -m pip install -e .[tests]

Error zsh: no matches found: .[tests]

After some research, I identified that the [] might have been interpreted by zsh as a wildcard to match files similar to tests. After wrapping it around quotations (i.e '[tests]'), I managed to succeed with installations.

Not sure if it's just an isolated issue — just thought to raise it up in case it's worth mentioning.

carltongibson commented 1 year ago

Yes it's a zsh vs bash thing. You could suggest a change there if you'd like! Thanks.

learningboiz commented 1 year ago

Sure thing, I've raised a PR regarding this. Sorry it took awhile — was swamped recently.