search

django / channels

Developer-friendly asynchrony for Django
https://channels.readthedocs.io
BSD 3-Clause "New" or "Revised" License
6.11k stars 800 forks source link

More informative assert errors for WebsocketCommunicator. #2098

Closed hovi closed 6 months ago

hovi commented 6 months ago

Already happened to me twice, that this AssertionError got me puzzled for a bit (being channels newbie and coming back after months), until I figured out, what was going on (socket closed unexpectedly while I wanted to read from it).

Having this kind of informative message would give me immediate hint and make my debugging much faster.

carltongibson commented 6 months ago

If you can fix the lint error, we're good to go.

hovi commented 6 months ago

If you can fix the lint error, we're good to go.

I believe I just did. Are you squashing or should I cleanup commits?

carltongibson commented 6 months ago

Thanks @hovi 🎁

hovi commented 6 months ago

My pleasure, thanks for quick review!