license specifics

[amirreza8002]

hi sorry to bother, I'm rather unaware of how licenses work I've forked this package and made channels_valkey.

is it ok if i keep watch of this repo and mirror the changes to that package?

also for the future, if valkey becomes the defacto, I'm more than happy to move channels_valkey repo to django

[carltongibson]

Hi @amirreza8002

is it ok if i keep watch of this repo and mirror the changes to that package?

So licence is BSD 3-Clause — so you're free copy the code, as long as you maintain the original copyright notice and attribution.

also for the future, if valkey becomes the defacto, I'm more than happy to move channels_valkey repo to django

OK, cool, yes... something to think about.

Can I ask, what's the difference? Is it essentially just a s/redis/valkey/? As I understood it, I can run valkey and use all existing redis libraries without change. (Assuming version compatibility.)

Maybe there's a neutral rename to be had to save have two packages doing the same thing 🤔

[amirreza8002]

hi thanks for the answer🙏

for this project it was mostly just sed

except for lua scripts that need to be changed to use server.call() instead of redis.call()

and i changed the packaging to use uv.

also from time to time my tests timeout, i have not discovered the reason yet.

I'm not sure what the last sentence means

[bigfootjon]

I think Carlton's point is that it might make sense to have a single package that is able to handle the functionality of both "redis" and "valkey"

[amirreza8002]

hm

i think i can do that, if you want

i need to think on how to implement it cleanly, but it should be doable.

tho i'm not sure if channels_redis would be a proper name if a merge would be to happen.

[bigfootjon]

There's also redict. Considering the "redis fork wars" that are going on right now maybe the best move is to stay out of this and wait for the dust to settle and then make this package work for all well-used forks of redis.

I'm not sure such a merge needs to happen now, in other words.

[amirreza8002]

hi yes i was merely talking about the possibility