search

django / channels_redis

Redis channel layer backend for Django Channels
BSD 3-Clause "New" or "Revised" License
591 stars 196 forks source link

license specifics #402

Open amirreza8002 opened 5 days ago

amirreza8002 commented 5 days ago

hi sorry to bother, I'm rather unaware of how licenses work I've forked this package and made channels_valkey.

is it ok if i keep watch of this repo and mirror the changes to that package?

also for the future, if valkey becomes the defacto, I'm more than happy to move channels_valkey repo to django

carltongibson commented 5 days ago

Hi @amirreza8002

is it ok if i keep watch of this repo and mirror the changes to that package?

So licence is BSD 3-Clause — so you're free copy the code, as long as you maintain the original copyright notice and attribution.

also for the future, if valkey becomes the defacto, I'm more than happy to move channels_valkey repo to django

OK, cool, yes... something to think about.

Can I ask, what's the difference? Is it essentially just a s/redis/valkey/? As I understood it, I can run valkey and use all existing redis libraries without change. (Assuming version compatibility.)

Maybe there's a neutral rename to be had to save have two packages doing the same thing 🤔

amirreza8002 commented 5 days ago

hi thanks for the answer🙏

for this project it was mostly just sed

except for lua scripts that need to be changed to use server.call() instead of redis.call()

and i changed the packaging to use uv.

also from time to time my tests timeout, i have not discovered the reason yet.

I'm not sure what the last sentence means