search

django / daphne

Django Channels HTTP/WebSocket server
BSD 3-Clause "New" or "Revised" License
2.32k stars 256 forks source link

Detect address family when using --fd option #479

Open InvalidInterrupt opened 10 months ago

InvalidInterrupt commented 10 months ago

I believe this fixes #287.

The changes I've made to tests and setuptools automatic package discovery may be a little messy still.

carltongibson commented 10 months ago

Thanks for this @InvalidInterrupt. Just FYI I'll be a cycle or two to get to this, but have a couple of issues to pull together for a release.

InvalidInterrupt commented 10 months ago

A new utility package I added to the test dependencies seems not to advertise Python 3.7 support. I wasn't confident adding a dependency was the right call in the first place. Let me know if there's a strong opinion on how to handle this, but for now I'm going to push a fixup commit where I monkeypatch an HttpConnection instance.

carltongibson commented 10 months ago

@InvalidInterrupt If you'd like, better would be to drop Python 3.7, which is EOL now. If you'd like to take that on (and related cleanups) in a separate PR that would be great, and speed me up 😅

InvalidInterrupt commented 10 months ago

I can make a PR to remove 3.7 support, but I'm not exactly sure what other changes I should (or should not) make.

I'm inclined to keep the latest change regardless; I think this is less likely to result in trouble in the future. You can decide yourself once you have time to review it.

carltongibson commented 10 months ago

OK, super thanks @InvalidInterrupt. I will get to this as soon as I can (but targeting a fall release for a new version)

If you wanted to glance over the other open PRs and comment, that's handy too, but no stress.