django / daphne

Django Channels HTTP/WebSocket server
BSD 3-Clause "New" or "Revised" License
2.37k stars 266 forks source link

--noasgi won't serve static files #512

Open JulienPalard opened 4 months ago

JulienPalard commented 4 months ago

When running ./manage.py runserver --noasgi I don't get static files served.

This is because both daphne and django.contrib.staticfiles provides a runserver replacement. Running daphne's runserver with --noasgi just cause the real runserver to be used, giving no chance to the staticfiles runserver.

I don't know if there's an elegant solution here, maybe shadowing commands are not a good idea (I don't blame daphne, staticfiles does the same :D).

Maybe the elegant solution is to link from https://docs.djangoproject.com/en/5.0/howto/deployment/asgi/daphne/ to https://docs.djangoproject.com/en/5.0/ref/contrib/staticfiles/#django.contrib.staticfiles.views.serve for easy finding?

Running Django 5.0.6 with daphne 4.1.2 on Debian Trixie.

carltongibson commented 4 months ago

The simple thing here is to comment out Daphne from INSTALLED APPS if you don't actually want it.

The noasgi flag predates the runserver implementation.

karolyi commented 2 months ago

Same issue here. The idea is to use daphne with --noasgi so that django debug toolbar can provide the history view.

With running daphne, it senses a multi-process environment and shuts down the history panel:

https://django-debug-toolbar.readthedocs.io/en/latest/panels.html#history