benchmark workflow modified to include different systems, publish and…

django / django-asv

Benchmarks for Django using asv

MIT License

40 stars 12 forks source link

benchmark workflow modified to include different systems, publish and… #31

Closed deepakdinesh1123 closed 2 years ago

deepakdinesh1123 commented 2 years ago

benchmarks workflow modified to now include different versions of ubuntu and windows, I will add macOS later
build-results workflow added to build result history for the first commit of every month for the past 5 years
publish-results workflow added to publish the results in the form of a website

smithdc1 commented 2 years ago

Hey @deepakdinesh1123 wow good work, there's a lot going on here.

I'd appreciate other comments before doing anything else to validate my thoughts. Cc @carltongibson

I wonder if we can chunk it and break it into a few steps.

Maybe we could:

add the github page build worlflow. (Add a couple of benchmark runs to a results folder so theres something to see).
run the workflow with the cron to run it each day.
run a batch to build up some history.

I'll leave a few other comments in line.

deepakdinesh1123 commented 2 years ago

@smithdc1 I am having trouble adding the result history to this PR, can I close it and reopen it with the results and the history added? I keep running into the error saying you are currently not in a branch every time I commit something as the actions are being run in this repo too.

smithdc1 commented 2 years ago

, can I close it and reopen it with the results and the history added?

Of course. Also may be easier to add a few results / history as a separate, preliminary PR.

I'm assuming we're agreed that we want to store the results right here in this project. 🤔