Build up history for new benchmarks

django / django-asv

Benchmarks for Django using asv

MIT License

40 stars 12 forks source link

Build up history for new benchmarks #47

Open smithdc1 opened 2 years ago

smithdc1 commented 2 years ago

Hi @deepakdinesh1123

https://smithdc1.github.io/django-asv/ the website looks great with new results being added yesterday.

One thought is that when we're adding new benchmarks can we build up some history by running against the list of commits that you had? The aim being to build up a trend line?

What do you think?

deepakdinesh1123 commented 2 years ago

Hi @smithdc1

Should I also add the history for python versions 3.8 and 3.9 for all the benchmarks? If yes, I think it might be better to add them as a separate PR.

smithdc1 commented 2 years ago

That sounds good, if possible.

Separate prs sounds good too.

We will need to think about maintainability going forward. That is, how do we add and remove python versions. Does it "just work" (tm) or is there something that will cause issues?

deepakdinesh1123 commented 2 years ago

Since miniconda is being used by ASV adding or removing python versions does not cause any problems, but adding versions of python that are not supported by the version of Django being benchmarked causes the benchmarks to fail but this won't be a problem since --strict option is not used when building results history.