search

django / django-asv

Benchmarks for Django using asv
MIT License
40 stars 12 forks source link

Migrating benchmarks from djangobench which use run_comparison_benchmark #5

Open deepakdinesh1123 opened 2 years ago

deepakdinesh1123 commented 2 years ago

I was migrating some of the benchmarks from djangobench and I noticed that the benchmarks default_middleware and multi_value_dict use the utils.run_comparison_benchmark method to compare two benchmarks, ASV does not support a direct comparison between different benchmark methods. How should I implement this?

smithdc1 commented 2 years ago

In the case of multi_value_dict its done to compare to a pure dictionary. I think it's fine to just benchmark the django class.

IIRC this is one of the core django classes so this one area we would like to keep track of. I'd expect small gains here will quickly add up.