django / django-asv

Benchmarks for Django using asv
MIT License
40 stars 12 forks source link

request response benchmarks added #65

Closed deepakdinesh1123 closed 2 years ago

deepakdinesh1123 commented 2 years ago

I have added two request-response benchmarks

carltongibson commented 2 years ago

This looks good @deepakdinesh1123 let me have a play this afternoon 👍

kezabelle commented 2 years ago

I happened to stumble across this in my GH timeline yesterday (hi!), and just wanted to drop a quick note, apologies for barging in.

I don't think it's a substantial issue (and it's certainly better than nothing!) but these two additions (DefaultMiddleWareBench and HttpMethods) are also implicitly testing the performance characteristics of the RequestFactory and Client implementations, I think? If, for whatever reason, either of those got slower (or faster), there'd potentially be a deviation that looks more positive/negative than it actually is?

carltongibson commented 2 years ago

Hey @kezabelle 👋.