django / django-contrib-comments

BSD 3-Clause "New" or "Revised" License
614 stars 196 forks source link

get_comment_create_data() got an unexpected keyword argument 'site_id' #115

Closed nordbit closed 7 years ago

nordbit commented 7 years ago

in: views/comments.py forms.py

Django==1.10.5 & django-contrib-comments==1.7.3/current

No error with oldest version django-contrib-comments == 1.7.2

claudep commented 7 years ago

I guess you have your own get_comment_create_data method? I'd then suggest to add **kwargs in the signature of your version. This was changed in https://github.com/django/django-contrib-comments/commit/1ab69cb122418c973e27210558d11bb3fba921f6