Make sites optional - Githubissues

django / django-contrib-comments

BSD 3-Clause "New" or "Revised" License

614 stars 196 forks source link

Make sites optional #119

Open tisdall opened 7 years ago

tisdall commented 7 years ago

As mentioned in #15, this change is to continue supporting the "sites" framework, but also make it work without it so it's now optional.

NOTE:

there's one translatable string added (I wanted to retain the existing string so existing translations would continue working. The new string is the same but with the URL and linefeeds removed.)
tests haven't been changed to test for running with no SITE_ID or sites framework installed. Should all the tests be run twice, once with sites and once without?

tisdall commented 7 years ago

hmm... I'm not that familiar with test runner.. I didn't make changes to the tests so I thought they'd continue to work, but the Travis errors indicate it's having issues setting up the DB. ValueError: Related model u'sites.Site' cannot be resolved Shouldn't that have been resolved by the list of installed apps?