search

django / django-contrib-comments

BSD 3-Clause "New" or "Revised" License
619 stars 197 forks source link

Release a new version to resolve Django 2.1 compatibility #137

Closed dcollinsn closed 6 years ago

dcollinsn commented 6 years ago

Currently the most current version of django-contrib-comments on pypi is 1.8.0, which is not compatible with Django 2.1, due to views/utils.py's use of django.utils.http's is_safe_url, which had an API change. This issue is resolved by https://github.com/django/django-contrib-comments/commit/e94b557f8fb0fd8e7272e0168a688083086d21ce#diff-79c5990d4a074dd413b23f20daa4312e .

Please consider cutting a release of the current master branch whenever possible to add compatibility with Django 2.1. Thanks!

claudep commented 6 years ago

1.9.0 has just been released.