search

django / django-contrib-comments

BSD 3-Clause "New" or "Revised" License
614 stars 196 forks source link

Adapted initial migration to not cause new migration with Django 4 #181

Closed claudep closed 2 years ago

claudep commented 2 years ago

Great, could you please also check that if returning to Django 3.2, the same No changes detected is output?

atodorov commented 2 years ago 
(kiwi_django3) [senko@localhost Kiwi]$ pip freeze | grep Django
Django==3.2.11

(kiwi_django3) [senko@localhost Kiwi]$ pip freeze | grep django-contrib-comments
django-contrib-comments @ file:///home/senko/django-contrib-comments/dist/django-contrib-comments-2.1.9.tar.gz

$ ./manage.py makemigrations
No changes detected
claudep commented 2 years ago

Awesome, thanks!

atodorov commented 2 years ago

@claudep do you mind bumping the version on PyPI ?

claudep commented 2 years ago

Sure, I'll plan that for the next days.