search

django / django-contrib-comments

BSD 3-Clause "New" or "Revised" License
619 stars 197 forks source link

Update forms.py to pass W3C validation #94

Closed PieroV closed 8 years ago

PieroV commented 8 years ago

W3 validator complains about maxlength attributes on hidden fields, so I've removed maxlength and minlength from security_hash object.

charettes commented 8 years ago

You want to remove the attributes from the widget, not the form field.

claudep commented 8 years ago

Interesting. In fact, I wonder if this is something that Django could cope with when rendering the hidden input. It might be worth creating a ticket in Django.

PieroV commented 8 years ago

Yep, you're right, I didn't thought it affects validation too.

Sorry and thanks anyway :simple_smile:

claudep commented 8 years ago

I'm closing this PR as I opened https://code.djangoproject.com/ticket/27015