django / django-docker-box

Run the Django test suite across all supported databases and python versions
120 stars 37 forks source link

Use `POSTGRES_VERSION` > 10 in .env file #30

Closed abhiabhi94 closed 3 years ago

abhiabhi94 commented 3 years ago

Inside the README, it is mentioned that the default version for postgres is 10.0

https://github.com/django/django-docker-box/blob/66e23309e61f499ffa151ebff2e63583f8f38514/README.md#configuration

Although the environment variable passed to Dockerfile sets the value for POSTGRES_VERSION to 9.6

https://github.com/django/django-docker-box/blob/66e23309e61f499ffa151ebff2e63583f8f38514/.env#L2

The support for postgres 9.6 was dropped in https://github.com/django/django/commit/5371342ed66f5ff9feae9dc4586ec43830bbeca6 and hence the tests crash for main branch on django.