Oracle setup seems to be broken.

django / django-docker-box

Run the Django test suite across all supported databases and python versions

116 stars 37 forks source link

Oracle setup seems to be broken. #4

Open charettes opened 4 years ago

charettes commented 4 years ago

It looks like referenced image is not publicly available anymore

docker-compose run oracle-db
Pulling oracle-db (sath89/oracle-12c:)...
ERROR: pull access denied for sath89/oracle-12c, repository does not exist or may require 'docker login': denied: requested access to the resource is denied

https://hub.docker.com/r/sath89/oracle-12c/ is a 404

orf commented 4 years ago

Honestly, I think we should bite the bullet and try to use the official Oracle image from the Oracle container registry.

What's unfortunate is we will not be able to run this on the CI though. I'm guessing these public docker images break some kind of licensing, which is why they are being removed. See: https://old.reddit.com/r/docker/comments/ail87k/my_image_with_10m_pulls_has_just_gone_completely/?st=jzcw7ohs&sh=cbadbdc2 and the linked issue

oduvan commented 3 years ago

any progress with that?

InvalidInterrupt commented 3 years ago

I've hacked together a version that uses 18c XE at https://github.com/InvalidInterrupt/django-docker-box/tree/oracle-xe that may be suitable for local testing. It also works around the sudo issue in the entrypint script.

There was some discussion regarding Oracle making XE images officially (and maybe publicly?) available here: https://github.com/oracle/docker-images/issues/1156

awtimmering commented 2 years ago

truevoly/oracle-12c seems to have been around for 3 years. Could we switch to that for the time being in our docker-compose.yml? Looks like a PR for that change has been sitting since 2019.

jpnauta commented 1 year ago

For anyone else looking into using this project to run Oracle: the latest version of Django (5.0) requires Oracle 19 or later - as such, neither sath89/oracle-12c nor truevoly/oracle-12c will work anymore.

If anyone attempts to fix this in the future, here are some tips:

oracle_entrypoint.sh is broken with an error saying that sudo isn't installed. To resolve this, copy from this commit.
I got an error TNS:listener does not currently know of service requested in connect descriptor. To resolve this, make a change like this in settings/test_oracle.py
If you run into error ORA-12528: TNS:listener: all appropriate instances are blocking new connections, you will need to expose port 5500 for oracle-db in docker-compose.yml

Good luck to you! Gotta love Oracle 🙄

ngnpope commented 1 month ago

For anyone interested in this, I have Oracle working on the main branch of my fork.

I have a bunch of tidying up to do, but hopefully in the coming months we can get it rolled back in upstream.

charettes commented 1 month ago

Super exciting stuff @ngnpope that would make building new features on Oracle less of a pain for sure. Let me know if you want someone to QA your work locally when you're done tidying it up.