search

django / django-docker-box

Run the Django test suite across all supported databases and python versions
120 stars 37 forks source link

Test via Github actions? #9

Open apollo13 opened 5 years ago

apollo13 commented 5 years ago

I just saw that Github Actions nowadays allows docker-compose tests, which would allow us to fully run (aside from oracle and the likes) the Django testsuite in github actions. I think if we were able to get that running we'd have a really nice testsuite, what do you think?

https://github.blog/2019-08-08-github-actions-now-supports-ci-cd/#fast-ci-cd-for-any-os-any-language-and-any-cloud and an example in https://github.com/peter-evans/docker-compose-actions-workflow

If we get this running I think we would be able to fully enable this for django itself.

orf commented 5 years ago

Awesome! I think this is the perfect test-bed to try it. If you sign up for the beta and give access to the Django organization we can get started.

apollo13 commented 5 years ago

I have requested access for Django, might take a few days. That said apparently using actions to replace jenkins might be a bit hard :( https://jasonet.co/posts/use-github-actions-for-ci/#running-ci-on-pull-requests-from-forks (I have yet to figure out if this is still the case, but looks like it)

orf commented 5 years ago

Ok, awesome. I expect that rather weird limitation to be fixed before GA, and there are apparently workarounds.

I’m concerned about MacOS not supporting docker though. It would be awesome to improve our coverage and testing there, as I expect MacOS is used by a large portion of people developing with Django. If we go live with this, we might need a special test step for MacOS that doesn’t involve any of these compose definitions.

Could you update this ticket once/if we are accepted, and we can at least get it working on master and see what we think. If we find it’s not suitable right now, Azure pipelines and Travis are a great starting point in replacing Jenkins.

apollo13 commented 5 years ago

@orf Looks like actions are live now for django org. I got no notification from github, so I cannot tell you when that did happen.