django / django-localflavor

Country-specific Django helpers, formerly of contrib fame
https://django-localflavor.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
828 stars 290 forks source link

added areas in Kuwait #296

Closed Dreamersoul closed 7 years ago

Dreamersoul commented 7 years ago

Please replace these instructions with a description of your change. The 'New Fields Only' section should be removed if your pull request doesn't add any new fields.

Thanks for your contribution!

A checklist is included below which helps us keep the code contributions consistent and helps speed up the review process. You can add additional commits to your pull request if you haven't met all of these points on your first version.

All Changes

New Fields Only

Dreamersoul commented 7 years ago

i dont know why but the isort --recursive --line-width 120 localflavor tests changed all the test files for some reason

sorry if i missed something this is the first time i contribute here please let me know if something is missing

Dreamersoul commented 7 years ago

are there any core contributors that can help me with this PR? i dont know why it is failing

claudep commented 7 years ago

Hey Hamad, Not related to the failure, but you should first revert all the blank line removal in your second commit. These unneeded changes make your pull request more difficult to review. Then, follow the advice in the failure: set self.maxDiff = None in your test case, and you might then see where is the output difference.

codecov-io commented 7 years ago

Codecov Report

Merging #296 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #296      +/-   ##
=========================================
+ Coverage   96.29%   96.3%   +<.01%     
=========================================
  Files         151     152       +1     
  Lines        4214    4221       +7     
  Branches      579     579              
=========================================
+ Hits         4058    4065       +7     
  Misses         97      97              
  Partials       59      59
Impacted Files Coverage Δ
localflavor/kw/kw_areas.py 100% <100%> (ø)
localflavor/kw/forms.py 89.58% <100%> (+0.94%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 961fd7d...8cdaa74. Read the comment docs.

Dreamersoul commented 7 years ago

Thank you @claudep I have reverted what isort did to the files not related to my commit and the tests pass now! However I don't know what to do to satisfy the following requirement:

Add .. versionadded:: <next-version> comment markers to new
localflavors.
claudep commented 7 years ago

You can grep the code for versionadded to see what it looks like. See some docstrings of https://github.com/django/django-localflavor/blob/master/localflavor/au/validators.py for example.

Dreamersoul commented 7 years ago

@claudep alright done :+1: thanks for your help :smile:

benkonrath commented 7 years ago

Merged via e51e52f4968cdb18d3b1f30189f929becfe3f340.

Thanks!