ghost commented 7 years ago

Please replace these instructions with a description of your change. The 'New Fields Only' section should be removed if your pull request doesn't add any new fields.

Thanks for your contribution!

A checklist is included below which helps us keep the code contributions consistent and helps speed up the review process. You can add additional commits to your pull request if you haven't met all of these points on your first version.

All Changes

[x] Add an entry to the docs/changelog.rst describing the change.
[x] Add an entry for your name in the docs/authors.rst file if it's not already there.
[x] Adjust your imports to a standard form by running this command:

isort --recursive --line-width 120 localflavor tests

New Fields Only

[x] Prefix the country code to all fields.
[x] Field names should be easily understood by developers from the target localflavor country. This means that English translations are usually not the best name unless it's for something standard like postal code, tax / VAT ID etc.
[x] Prefer 'PostalCodeField' for postal codes as it's international English; ZipCode is a term specific to the United States postal system.
[x] Add meaningful tests. 100% test coverage is not required but all validation edge cases should be covered.
[x] Add .. versionadded:: <next-version> comment markers to new localflavors.
[x] Add documentation for all fields.

codecov-io commented 7 years ago

Codecov Report

Merging #300 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #300   +/-   ##
======================================
  Coverage    96.3%   96.3%           
======================================
  Files         152     152           
  Lines        4221    4221           
  Branches      579     579           
======================================
  Hits         4065    4065           
  Misses         97      97           
  Partials       59      59

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a984b6a...2929e44. Read the comment docs.

benkonrath commented 7 years ago

I think you made a mistake. You probably didn't mean to send a pull request for old 'add-changes-file' branch from the localflavor git repo. I'm closing this pull request.

django / django-localflavor

iran localflavor #300

Codecov Report