search

django / django-localflavor

Country-specific Django helpers, formerly of contrib fame
https://django-localflavor.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
828 stars 290 forks source link

Add Brazilian Model Fields #341

Closed andrelramos closed 5 years ago

andrelramos commented 6 years ago

Closes https://github.com/django/django-localflavor/issues/334

codecov-io commented 6 years ago

Codecov Report

Merging #341 into master will increase coverage by 0.19%. The diff coverage is 97.7%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
+ Coverage   95.82%   96.01%   +0.19%     
==========================================
  Files         153      158       +5     
  Lines        3878     4063     +185     
  Branches      517      545      +28     
==========================================
+ Hits         3716     3901     +185     
  Misses         98       98              
  Partials       64       64
Impacted Files Coverage Δ
localflavor/nl/forms.py 97.36% <ø> (ø) :arrow_up:
localflavor/nl/models.py 100% <ø> (ø) :arrow_up:
localflavor/nl/validators.py 100% <ø> (ø) :arrow_up:
localflavor/br/forms.py 100% <100%> (+1.73%) :arrow_up:
localflavor/br/models.py 100% <100%> (ø) :arrow_up:
localflavor/br/validators.py 96.55% <96.55%> (ø)
localflavor/ar/forms.py 92.85% <0%> (ø) :arrow_up:
localflavor/generic/validators.py 100% <0%> (ø) :arrow_up:
localflavor/md/choices.py 100% <0%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0528736...866e27d. Read the comment docs.

andrelramos commented 6 years ago

@benkonrath Thank you for your suggestions!

I finished the requested changes. Can you take a look again?

I'm very glad to know that these changes will be introduced in next release. :grinning:

benkonrath commented 6 years ago

We'll have to push this to 2.2.

benkonrath commented 6 years ago

localflavor isn't tied to using the same release number as Django. I'd like to aim to make the 2.2 release in the first week of December (tentatively of course). This should be a good rallying point for this PR and other new features.

andrelramos commented 5 years ago

@benkonrath I did the last changes request. I think it's done now.

benkonrath commented 5 years ago

I ended up rebasing and squashing the commit in #365 just to make it a little cleaner. Thanks again for your contribution and sorry for the delay in getting this merged.