django / django-localflavor

Country-specific Django helpers, formerly of contrib fame
https://django-localflavor.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
813 stars 289 forks source link

Ie model fields #360

Closed paulcunnane closed 5 years ago

paulcunnane commented 5 years ago

This change adds an "EircodeField" to the Irish local flavour. An Eircode is an Irish postcode (https://www.eircode.ie). The format of the Eircode is validated, but its existence is not.

Thanks for your contribution!

A checklist is included below which helps us keep the code contributions consistent and helps speed up the review process. You can add additional commits to your pull request if you haven't met all of these points on your first version.

All Changes

New Fields Only

benkonrath commented 5 years ago

Thanks for your contribution. Can you rebase this branch with master? That will pickup the latest changes and fixes to the CI config and the tests should pass. I'll do the review once you've rebased. Thanks.

paulcunnane commented 5 years ago

I think that's done now (not a git expert!)

codecov-io commented 5 years ago

Codecov Report

Merging #360 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #360      +/-   ##
==========================================
+ Coverage   95.93%   95.94%   +0.01%     
==========================================
  Files         157      157              
  Lines        3981     3996      +15     
  Branches      523      525       +2     
==========================================
+ Hits         3819     3834      +15     
  Misses         98       98              
  Partials       64       64
Impacted Files Coverage Δ
localflavor/generic/validators.py 100% <ø> (ø) :arrow_up:
localflavor/ie/forms.py 100% <100%> (ø) :arrow_up:
localflavor/no/forms.py 87.35% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7cb223b...c0d32d8. Read the comment docs.