benkonrath commented 5 years ago

This PR removes the isort check in the CI as suggested by a couple of users. I still like the consistency this brings but too many contributors are running into problems with this check so it's time to remove it. We can always run isort manually once in a while if we want to keep things consistent with the imports.

Any thoughts or opinion on this?

codecov-io commented 5 years ago

Codecov Report

Merging #362 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #362   +/-   ##
=======================================
  Coverage   95.93%   95.93%           
=======================================
  Files         157      157           
  Lines        3981     3981           
  Branches      523      523           
=======================================
  Hits         3819     3819           
  Misses         98       98           
  Partials       64       64

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6fad8fd...a7751f8. Read the comment docs.

claudep commented 5 years ago

I don't care much, feel free to make your decision.

benkonrath commented 5 years ago

Ok, thanks for your input.

django / django-localflavor

Remove isort from CI. #362

Codecov Report