search

django / django-localflavor

Country-specific Django helpers, formerly of contrib fame
https://django-localflavor.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
813 stars 289 forks source link

Removed Python 2 compatibility #369

Closed claudep closed 5 years ago

claudep commented 5 years ago

This removes Python 2 compatibility and makes django-localflavor run with next Django version (3.0).

codecov-io commented 5 years ago

Codecov Report

Merging #369 into master will decrease coverage by 0.13%. The diff coverage is 97.86%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #369      +/-   ##
=========================================
- Coverage   95.94%   95.8%   -0.14%     
=========================================
  Files         161     160       -1     
  Lines        4095    3959     -136     
  Branches      528     528              
=========================================
- Hits         3929    3793     -136     
  Misses        100     100              
  Partials       66      66
Impacted Files Coverage Δ
localflavor/tr/tr_provinces.py 100% <ø> (ø) :arrow_up:
localflavor/pe/pe_region.py 100% <ø> (ø) :arrow_up:
localflavor/si/si_postalcodes.py 100% <ø> (ø) :arrow_up:
localflavor/ro/ro_counties.py 100% <ø> (ø) :arrow_up:
localflavor/uy/util.py 100% <ø> (ø) :arrow_up:
localflavor/br/br_states.py 100% <ø> (ø) :arrow_up:
localflavor/generic/countries/sepa.py 100% <ø> (ø) :arrow_up:
localflavor/co/co_departments.py 100% <ø> (ø) :arrow_up:
localflavor/cn/cn_provinces.py 100% <ø> (ø) :arrow_up:
localflavor/py_/py_department.py 100% <ø> (ø) :arrow_up:
... and 145 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 28b48d4...52b0de1. Read the comment docs.

benkonrath commented 5 years ago

Thanks for this! I was roughly planning a 2.2 release at the end of the month. I think it's better to merge this after the 2.2 release so that we can support Django 1.11 & 2.2 in our 2.2 release. What do you think?

claudep commented 5 years ago

Sure, that's a good plan!

claudep commented 5 years ago

Just rebased the branch.

claudep commented 5 years ago

See https://code.djangoproject.com/ticket/30399 about the failures we get on the master branch.

claudep commented 5 years ago

The PR was committed, I triggered a new build and the tests now pass on master!