search

django / django-localflavor

Country-specific Django helpers, formerly of contrib fame
https://django-localflavor.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
813 stars 289 forks source link

Deprecate generic.checksums.luhn and ean #370

Closed benkonrath closed 5 years ago

benkonrath commented 5 years ago

I've been meaning to do this for a while. As the code suggests, my plan is to remove the generic.checksums.luhn and generic.checksums.ean functions in 3.0 - users should just use python-stdnum directly.

@claudep If you have time a review and your thoughts on this plan would be helpful. Thanks.

codecov-io commented 5 years ago

Codecov Report

Merging #370 into master will decrease coverage by 0.05%. The diff coverage is 90.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #370      +/-   ##
==========================================
- Coverage      96%   95.95%   -0.06%     
==========================================
  Files         160      160              
  Lines        4058     4051       -7     
  Branches      528      525       -3     
==========================================
- Hits         3896     3887       -9     
- Misses         98       99       +1     
- Partials       64       65       +1
Impacted Files Coverage Δ
localflavor/za/forms.py 100% <100%> (ø) :arrow_up:
localflavor/generic/validators.py 100% <100%> (ø) :arrow_up:
localflavor/fr/forms.py 100% <100%> (ø) :arrow_up:
localflavor/hr/forms.py 94.23% <100%> (ø) :arrow_up:
localflavor/il/forms.py 100% <100%> (ø) :arrow_up:
localflavor/ca/forms.py 96.29% <100%> (ø) :arrow_up:
localflavor/gr/forms.py 90.32% <50%> (ø) :arrow_up:
localflavor/generic/checksums.py 88.88% <81.81%> (-11.12%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e1936aa...a1a6db0. Read the comment docs.