Closed shahwan42 closed 5 years ago
Merging #374 into master will increase coverage by
0.01%
. The diff coverage is97.22%
.
@@ Coverage Diff @@
## master #374 +/- ##
==========================================
+ Coverage 95.8% 95.81% +0.01%
==========================================
Files 160 162 +2
Lines 3959 3995 +36
Branches 528 533 +5
==========================================
+ Hits 3793 3828 +35
Misses 100 100
- Partials 66 67 +1
Impacted Files | Coverage Δ | |
---|---|---|
localflavor/eg/choices.py | 100% <100%> (ø) |
|
localflavor/eg/forms.py | 97.05% <97.05%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 163785f...f66414d. Read the comment docs.
Thanks for the PR! I'll have time to review this in the next few days. Thanks for your patience.
Thanks again for your contribution!
All Changes
[x] Add an entry to the docs/changelog.rst describing the change.
[x] Add an entry for your name in the docs/authors.rst file if it's not already there.
New Fields Only
[x] Prefix the country code to all fields.
[x] Field names should be easily understood by developers from the target localflavor country. This means that English translations are usually not the best name unless it's for something standard like postal code, tax / VAT ID etc.
[x] Add meaningful tests. 100% test coverage is not required but all validation edge cases should be covered.
[x] Add
.. versionadded:: <next-version>
comment markers to new localflavors.[x] Add documentation for all fields.