django / django-localflavor

Country-specific Django helpers, formerly of contrib fame
https://django-localflavor.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
813 stars 289 forks source link

Extend Danish post code field with small Danish islands #380

Closed HenrikOssipoff closed 4 years ago

HenrikOssipoff commented 5 years ago

In 2017 a lot of small Danish islands gained their own independant postal codes, which were missing from DK_POSTCALCODES. Also added 3 new service postal codes (ones below 1000).

All Changes

HenrikOssipoff commented 5 years ago

Reference Excel sheet from PostNord: https://www.postnord.dk/globalassets/danmark/.excel-docs/postnummerfil-til-download-06-19.xlsx

codecov-io commented 5 years ago

Codecov Report

Merging #380 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #380   +/-   ##
=======================================
  Coverage   95.85%   95.85%           
=======================================
  Files         161      161           
  Lines        3978     3978           
  Branches      530      530           
=======================================
  Hits         3813     3813           
  Misses         99       99           
  Partials       66       66
Impacted Files Coverage Δ
localflavor/dk/dk_postalcodes.py 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0216523...f92aee0. Read the comment docs.

HenrikOssipoff commented 4 years ago

@benkonrath Thank you for the comment, I've updated the PR as per your suggestion. Let me know if it's OK, and I'll squash everything.

benkonrath commented 4 years ago

Looks good.