search

django / django-localflavor

Country-specific Django helpers, formerly of contrib fame
https://django-localflavor.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
813 stars 289 forks source link

Added cities of Israel and postal code regions in Great Britain #381

Closed theBrownBug closed 4 years ago

theBrownBug commented 4 years ago

Added cities in Israel. Added postal code regions of Great Britain

Source : https://www.britannica.com/topic/list-of-cities-and-towns-in-Israel-2060226 https://en.wikipedia.org/wiki/List_of_postcode_areas_in_the_United_Kingdom

codecov-io commented 4 years ago

Codecov Report

Merging #381 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
+ Coverage   95.85%   95.85%   +<.01%     
==========================================
  Files         161      162       +1     
  Lines        3978     3980       +2     
  Branches      530      530              
==========================================
+ Hits         3813     3815       +2     
  Misses         99       99              
  Partials       66       66
Impacted Files Coverage Δ
localflavor/il/cities.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fcda7f3...42a57d1. Read the comment docs.

claudep commented 4 years ago

Thanks, but please do not mix two unrelated changes in the same pull request. Please split them into two PRs.

theBrownBug commented 4 years ago

Noted.

benkonrath commented 4 years ago

I'm closing this PR - please create separate PRs for each logical change you'd like to contribute. Thanks.