django / django-localflavor

Country-specific Django helpers, formerly of contrib fame
https://django-localflavor.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
813 stars 289 forks source link

Add Kalimantan Utara in list of provinces of Indonesia #385

Closed int2k closed 4 years ago

int2k commented 4 years ago

Add Kalimantan Utara province for Indonesia's List of provinces

Thanks for your contribution!

A checklist is included below which helps us keep the code contributions consistent and helps speed up the review process. You can add additional commits to your pull request if you haven't met all of these points on your first version.

All Changes

codecov-io commented 4 years ago

Codecov Report

Merging #385 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #385   +/-   ##
=======================================
  Coverage   95.85%   95.85%           
=======================================
  Files         161      161           
  Lines        3978     3978           
  Branches      530      530           
=======================================
  Hits         3813     3813           
  Misses         99       99           
  Partials       66       66
Impacted Files Coverage Δ
localflavor/id_/id_choices.py 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fcda7f3...b17925b. Read the comment docs.

benkonrath commented 4 years ago

Thanks for the PR! It would be better if you split this change into 2 separate pull requests. The easiest thing to do is remove the changes to the national identity number and make a new PR. Thanks.

int2k commented 4 years ago

reverted the change and moved to different PR

benkonrath commented 4 years ago

Sorry for the delay on this. Thanks again for the fix.