django / django-localflavor

Country-specific Django helpers, formerly of contrib fame
https://django-localflavor.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
813 stars 289 forks source link

Change National Identity number validation for women #386

Closed int2k closed 4 years ago

int2k commented 4 years ago

Change test to use translated messages

Please replace these instructions with a description of your change. The 'New Fields Only' section should be removed if your pull request doesn't add any new fields.

Thanks for your contribution!

A checklist is included below which helps us keep the code contributions consistent and helps speed up the review process. You can add additional commits to your pull request if you haven't met all of these points on your first version.

All Changes

codecov-io commented 4 years ago

Codecov Report

Merging #386 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
+ Coverage   95.85%   95.85%   +<.01%     
==========================================
  Files         161      161              
  Lines        3978     3981       +3     
  Branches      530      531       +1     
==========================================
+ Hits         3813     3816       +3     
  Misses         99       99              
  Partials       66       66
Impacted Files Coverage Δ
localflavor/id_/forms.py 91.52% <100%> (+0.22%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fcda7f3...34b8244. Read the comment docs.

codecov-io commented 4 years ago

Codecov Report

Merging #386 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
+ Coverage   95.85%   95.85%   +<.01%     
==========================================
  Files         161      161              
  Lines        3978     3981       +3     
  Branches      530      531       +1     
==========================================
+ Hits         3813     3816       +3     
  Misses         99       99              
  Partials       66       66
Impacted Files Coverage Δ
localflavor/id_/forms.py 91.52% <100%> (+0.22%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fcda7f3...34b8244. Read the comment docs.

benkonrath commented 4 years ago

I noticed that this was in draft mode so I "published" it. Sorry for the delay in looking at this. I might have skipped it because of the draft mode. In any case, it looks good. Thanks for the PR!