SyafiqTermizi commented 4 years ago

Please replace these instructions with a description of your change. The 'New Fields Only' section should be removed if your pull request doesn't add any new fields.

Thanks for your contribution!

A checklist is included below which helps us keep the code contributions consistent and helps speed up the review process. You can add additional commits to your pull request if you haven't met all of these points on your first version.

All Changes

[x] Add an entry to the docs/changelog.rst describing the change.
[x] Add an entry for your name in the docs/authors.rst file if it's not already there.

New Fields Only

[x] Prefix the country code to all fields.
[x] Field names should be easily understood by developers from the target localflavor country. This means that English translations are usually not the best name unless it's for something standard like postal code, tax / VAT ID etc.
[ ] Prefer 'PostalCodeField' for postal codes as it's international English; ZipCode is a term specific to the United States postal system.
[x] Add meaningful tests. 100% test coverage is not required but all validation edge cases should be covered.
[x] Add .. versionadded:: <next-version> comment markers to new localflavors.
[x] Add documentation for all fields.

SyafiqTermizi commented 4 years ago

Hi, could someone tell me why is it failing on python 3.5

claudep commented 4 years ago

Don't worry, that's the prospector job, that's probably a totally unrelated issue.

jeanlucmongrain commented 4 years ago

ImportError: No module named 'pylint.exceptions'

look like a version mismatch with prospector dependency

benkonrath commented 4 years ago

I just fixed the import error failure.

@SyafiqTermizi Could you rebase this PR when you have a chance? Thanks!

SyafiqTermizi commented 4 years ago

@benkonrath I have rebased my PR 😄

codecov-io commented 4 years ago

Codecov Report

Merging #387 into master will increase coverage by 0.02%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #387      +/-   ##
==========================================
+ Coverage   95.85%   95.88%   +0.02%     
==========================================
  Files         161      162       +1     
  Lines        3983     4006      +23     
  Branches      528      532       +4     
==========================================
+ Hits         3818     3841      +23     
  Misses         99       99              
  Partials       66       66

Impacted Files	Coverage Δ
localflavor/my/forms.py	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 89e8565...c4820d8. Read the comment docs.

benkonrath commented 4 years ago

@SyafiqTermizi Thanks and sorry for the delay. I'll be able to do a full review later in the week - hopefully on Wednesday or Thursday.

SyafiqTermizi commented 4 years ago

Hi, @benkonrath , I do agree with your points. So I've updated my PR based on your suggestion. Hopefully, this PR can be merged soon 😄

benkonrath commented 4 years ago

Looks good. Thanks!

django / django-localflavor

Add malaysian flavor #387

Codecov Report