django / django-localflavor

Country-specific Django helpers, formerly of contrib fame
https://django-localflavor.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
813 stars 289 forks source link

Switch ARCBUField to use python-stdnum #391

Closed arthurdejong closed 4 years ago

arthurdejong commented 4 years ago

This switches the (incorrect) implementation in ARCBUField to use the validation logic of python-stdnum.

A checklist is included below which helps us keep the code contributions consistent and helps speed up the review process. You can add additional commits to your pull request if you haven't met all of these points on your first version.

All Changes

codecov-io commented 4 years ago

Codecov Report

Merging #391 into master will decrease coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
- Coverage   95.87%   95.85%   -0.02%     
==========================================
  Files         161      161              
  Lines        3997     3983      -14     
  Branches      530      528       -2     
==========================================
- Hits         3832     3818      -14     
  Misses         99       99              
  Partials       66       66
Impacted Files Coverage Δ
localflavor/ar/forms.py 91.46% <100%> (-1.25%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 04dca27...582e3f2. Read the comment docs.

arthurdejong commented 4 years ago

Just one small request: Could you add a .. versionchanged:: 3.0 to the docstring? Thanks.

Done.

benkonrath commented 4 years ago

Thanks!