search

django / django-localflavor

Country-specific Django helpers, formerly of contrib fame
https://django-localflavor.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
813 stars 289 forks source link

3.0.1 release on 25 March 2020 #413

Closed benkonrath closed 4 years ago

benkonrath commented 4 years ago

See #410

benkonrath commented 4 years ago

@claudep Do you have time to update the translations from Transifex today? Sorry that I'm a little late asking. Tomorrow would also be ok. Thanks.

claudep commented 4 years ago

Hi Ben, I just realize that you accidentally reintroduced source comments in all po files in 9ebe417374, where only the en django.po should have been updated. Are you OK if I revert that commit?

benkonrath commented 4 years ago

Yeah, sure. Please revert the commit as needed.

I did notice there were more changes the last commit but I was using the invoke command which I assumed was more correct than when I manually update the base catalogue. Is this going to be a problem for the updated translations?

claudep commented 4 years ago

No, it should not. I guess you used the make_translations command without argument?

benkonrath commented 4 years ago

I guess you used the make_translations command without argument?

Yeah, looks like it. I'll be sure to use en as argument next next. I guess I assumed it would default to en and didn't look closely. I supposed I could have figured it out with the extra changes. Thanks for noticing and fixing it.

claudep commented 4 years ago

I'll update that invoke script, making translations for all languages should generally not happen in our current workflow. I'ts currently misleading.

claudep commented 4 years ago

Updated translations are in now.

benkonrath commented 4 years ago

3.0.1 has just been released to pypi. Thanks for the help @claudep!

claudep commented 4 years ago

:tada: