django / django-localflavor

Country-specific Django helpers, formerly of contrib fame
https://django-localflavor.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
813 stars 289 forks source link

fix error code on BRPostalCodeValidator #448

Closed Setti7 closed 2 years ago

Setti7 commented 2 years ago

Changes:

The BRPostalCodeValidator was using _('Invalid Postal Code') as an error code. But error codes should be in snakecase and not translatable. With this change the error code used is the default one (invalid).


Please replace these instructions with a description of your change. The 'New Fields Only' section should be removed if your pull request doesn't add any new fields.

Thanks for your contribution!

A checklist is included below which helps us keep the code contributions consistent and helps speed up the review process. You can add additional commits to your pull request if you haven't met all of these points on your first version.

All Changes


Questions:

benkonrath commented 2 years ago

Thank you for the bug fix. This was definitely an oversight.