vishalpandeynits
commented
2 years ago Hey @sandeepN06 , thanks for your contribution. I am reviewing this PR to reduce the load on maintainers. Please install tox and run the tox command to test your code locally, and make sure your code passes all tests before pushing your code into the main repository. you can get an installation guide in contributing.rst file of this repo.
@benkonrath I have tried to point out all mistakes, but I am requesting you to scrutinize again and add your points as well.
sandeepN06
Please replace these instructions with a description of your change. The 'New Fields Only' section should be removed if your pull request doesn't add any new fields.
Thanks for your contribution!
A checklist is included below which helps us keep the code contributions consistent and helps speed up the review process. You can add additional commits to your pull request if you haven't met all of these points on your first version.
All Changes
[ ✔] Add an entry to the docs/changelog.rst describing the change.
[ ✔] Add an entry for your name in the docs/authors.rst file if it's not already there.
New Fields Only
[✔ ] Prefix the country code to all fields.
[✔ ] Field names should be easily understood by developers from the target localflavor country. This means that English translations are usually not the best name unless it's for something standard like postal code, tax / VAT ID etc.
[ ✔] Prefer 'PostalCodeField' for postal codes as it's
international English; ZipCode is a term specific to the United
States postal system.
[ ✔] Add meaningful tests. 100% test coverage is not required but all validation edge cases should be covered.
[ ✔] Add
.. versionadded:: <next-version>comment markers to new localflavors.[ ✔] Add documentation for all fields.