django / django-localflavor

Country-specific Django helpers, formerly of contrib fame
https://django-localflavor.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
812 stars 289 forks source link

Added local-flavour for ghana #416 #460

Closed sandeepN06 closed 2 years ago

sandeepN06 commented 2 years ago

Please replace these instructions with a description of your change. The 'New Fields Only' section should be removed if your pull request doesn't add any new fields.

Thanks for your contribution!

A checklist is included below which helps us keep the code contributions consistent and helps speed up the review process. You can add additional commits to your pull request if you haven't met all of these points on your first version.

All Changes

New Fields Only

sandeepN06 commented 2 years ago

@benkonrath thanks for all the inputs and created a new PR . Kind request for a review @benkonrath

sandeepN06 commented 2 years ago

@benkonrath can i please know the status of this PR?

sandeepN06 commented 2 years ago

@benkonrath kind request for a review :)

benkonrath commented 2 years ago

@sandeepN06 I saw that you had some trouble with the last request so I went ahead and added a small test. I guess missed that the model was not tested in the Nepal localflavour. It would be great if you could make a PR to add that test.

Thanks again for your PR!

sandeepN06 commented 2 years ago

Thanks a lot @benkonrath . You are a great mentor , Thanks for answering all my doubts :)

benkonrath commented 2 years ago

You're welcome. :-)