Closed chmod77 closed 1 year ago
Is there a reason you closed this so quickly? Is there something I can help with?
Hi Ben,
I am still working on it. Apologies, I had opened that PR accidentally.
On Tue, Mar 28, 2023 at 1:02 PM Ben Konrath @.***> wrote:
Is there a reason you closed this so quickly? Is there something I can help with?
— Reply to this email directly, view it on GitHub https://github.com/django/django-localflavor/pull/482#issuecomment-1486567088, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKQXBT43KUQ2V5NBJQ6QMWDW6KZLNANCNFSM6AAAAAAWH73PUM . You are receiving this because you modified the open/close state.Message ID: @.***>
Please replace these instructions with a description of your change. The 'New Fields Only' section should be removed if your pull request doesn't add any new fields.
Thanks for your contribution!
A checklist is included below which helps us keep the code contributions consistent and helps speed up the review process. You can add additional commits to your pull request if you haven't met all of these points on your first version.
All Changes
[x] Add an entry to the docs/changelog.rst describing the change.
[x] Add an entry for your name in the docs/authors.rst file if it's not already there.
New Fields Only
[x] Prefix the country code to all fields.
[x] Field names should be easily understood by developers from the target localflavor country. This means that English translations are usually not the best name unless it's for something standard like postal code, tax / VAT ID etc.
[x] Prefer 'PostalCodeField' for postal codes as it's
international English; ZipCode is a term specific to the United
States postal system.
[ ] Add meaningful tests. 100% test coverage is not required but all validation edge cases should be covered.
[ ] Add
.. versionadded:: <next-version>
comment markers to new localflavors.[x] Add documentation for all fields.