Localflavor Sri Lanka: Support for Sri Lanka added in django-localflavor

skdishansachin commented 11 months ago

Support for Sri Lanka Added as requested by this issue https://github.com/django/django-localflavor/issues/491

What Fields are added ?

[x] Field for provinces of Sri Lanka.
[x] Field for districts of Sri Lanka.
[x] Field for Postal Code of Sri Lanka.

All Changes

[x] Add an entry to the docs/changelog.rst describing the change.
[x] Add an entry for your name in the docs/authors.rst file if it's not already there.

New Fields Only

[x] Prefix the country code to all fields.
[x] Field names should be easily understood by developers from the target localflavor country. This means that English translations are usually not the best name unless it's for something standard like postal code, tax / VAT ID etc.
[x] Prefer 'PostalCodeField' for postal codes as it's international English; ZipCode is a term specific to the United States postal system.
[x] Add meaningful tests. 100% test coverage is not required but all validation edge cases should be covered.
[x] Add .. versionadded:: <next-version> comment markers to new localflavors.
[x] Add documentation for all fields.

claudep commented 1 week ago

@benkonrath Do you think you could find some time in the near future to review this request?

benkonrath commented 1 week ago

@claudep Yeah. I'll try to dedicate a few hours to going through the PR backlog a bit in the next day or two. Thanks for the reminder.

claudep commented 1 week ago

@skdishansachin Please fix the test failures!

skdishansachin commented 1 week ago

Okay I will fix those test failures @claudep

benkonrath commented 6 days ago

@skdishansachin Please fix the tests and then I'll take a look at this PR. I don't know why I have to continually approve the test runs but I'll be quicker about doing this now that I know that they need to approved more than once.

skdishansachin commented 6 days ago

@benkonrath @claudep Hey, sorry about sending that review request before fixing the issues properly. I'll check it soon when I have time. Thanks!

benkonrath commented 6 days ago

No problem. There's no direct feedback since I have to approve and run the tests in github CI... and I haven't been on top of that. That makes it harder for you to know that things aren't working correctly. This PR is on my radar now and hopefully we can make some progress soon. :rocket:

django / django-localflavor

Localflavor Sri Lanka: Support for Sri Lanka added in django-localflavor #493