Class based views edit_account and edit_skills

django / djangopeople

A geographical community site for Django developers

https://people.djangoproject.com

MIT License

86 stars 44 forks source link

Class based views edit_account and edit_skills #11

Closed fhahn closed 13 years ago

brutasse commented 13 years ago

@fhahn thanks! I just made a couple of comments but that looks good! If you can adress them that'd be great.

@danfairs and @bezidejni, any other comments?

fhahn commented 13 years ago

@brutasse thank you for the comments! I was thinking about some kind of PersonMixin as well, but I didn't have enough time in the morning, but I've added it now

danfairs commented 13 years ago

Looks like you covered everything, @brutasse - thanks.

brutasse commented 13 years ago

Merged. Just tweaked PersonMixin a bit, see 0a6b5c7. Thanks @fhahn!

fhahn commented 13 years ago

thank you! I've avoided initial = super(EditAccountView, self).get_initial() because it caused a wired error in one project I'm working on, but it seems fine here.