search

django / djangopeople

A geographical community site for Django developers
https://people.djangoproject.com
MIT License
86 stars 44 forks source link

unable to change my location #24

Closed carljm closed 12 years ago

carljm commented 12 years ago

I've tried twice to update my location and save it, but each time after I do so I go back to my profile page and its still got the old location. Could be a cache issue, not sure.

brutasse commented 12 years ago

There is no caching in users locations so if should be immediately updated. Do you see any JavaScript error when you move the map? Is the location correct when you look at the post data?

carljm commented 12 years ago

No Javascript errors, everything seems to work correctly. The POST data has the correct new latitude, longitude, location description, country, region. After POSTing it reloads the change-location page, still with the correct location. But it doesn't save it - when I then navigate back to profile it still has my old location, and when I visit change-location again, it has the old location.

brutasse commented 12 years ago

Ah, after re-reading I see something's wrong. After the post you should get redirected to your profile page. Since it's not the case there must be a validation error somewhere and it's apparently not shown. I'll try to understand what's wrong, if you could send me an example of failing post data that'd be very helpful.

carljm commented 12 years ago

Here's POST data that fails: csrfmiddlewaretoken=QNOviqd1kx0CwrPaQ68MNc2Ky8tYg7MG&location_description=Rapid+City%2C+South+Dakota&country=US&latitude=44.07883004975277&longitude=-103.28332901005193&region=SD

When I first come to the change-profile page, there's a country dropdown but no region one. Then after scrolling the map around, the region dropdown appears (and, obviously, submits some data). Then after the page reload it's gone again. Dunno if that's relevant.

brutasse commented 12 years ago

Thanks a lot, I'll look in more details this week-end :)

On Thursday, 7 June 2012 at 23:47, Carl Meyer wrote:

Here's POST data that fails: csrfmiddlewaretoken=QNOviqd1kx0CwrPaQ68MNc2Ky8tYg7MG&location_description=Rapid+City%2C+South+Dakota&country=US&latitude=44.07883004975277&longitude=-103.28332901005193&region=SD

When I first come to the change-profile page, there's a country dropdown but no region one. Then after scrolling the map around, the region dropdown appears (and, obviously, submits some data). Then after the page reload it's gone again. Dunno if that's relevant.

Reply to this email directly or view it on GitHub: https://github.com/brutasse/djangopeople/issues/24#issuecomment-6188995

brutasse commented 12 years ago

@carljm not sure if you got notified by the commit I made. The issue should be fixed now, can you confirm? Thanks!

carljm commented 12 years ago

Yes, it is fixed, thank you!