django / djangoproject.com

Source code to djangoproject.com
https://www.djangoproject.com/
BSD 3-Clause "New" or "Revised" License
1.86k stars 937 forks source link

Add ids to "Local Django Communities" page #1474

Closed hmatsuuchi closed 4 months ago

hmatsuuchi commented 4 months ago

Summary: Anchor tag link list is not working due to lack of corresponding ids in elements

Page: https://www.djangoproject.com/community/local/

Code to fix: https://github.com/django/djangoproject.com/blob/dfa7429ec929c1b5985782c17008cbb5854649f8/djangoproject/templates/aggregator/local-django-community.html

How to fix: Change this [line: 20]: <div class="section"> to this: <div id="{{ local_django_community.grouper.title }}-meetups" class="section">

prabs222 commented 4 months ago

I have opened a PR #1475, which fixes this issue.

In addition to the line mentioned there were two other lines where either id was missing or was incorrect

hmatsuuchi commented 4 months ago

Thank you for taking care of that! I'll go ahead and close the issue. @prabs222