search

django / djangoproject.com

Source code to djangoproject.com
https://www.djangoproject.com/
BSD 3-Clause "New" or "Revised" License
1.86k stars 939 forks source link

Enable profiling of transactions in Sentry #1515

Closed tobiasmcnulty closed 2 months ago

tobiasmcnulty commented 2 months ago

https://docs.sentry.io/platforms/python/profiling/#enable-profiling

bmispelon commented 2 months ago

The document you linked states that:

The profiles_sample_rate setting is relative to the traces_sample_rate setting.

So I my math is right, that means only 1% of transactions will be profiled. Was that the intent?

tobiasmcnulty commented 2 months ago

@bmispelon Excellent catch! I missed that. I suppose I intended to set profiles_sample_rate=1.0, but I am open to any suggestions.

bmispelon commented 2 months ago

It's unclear to me what kind of overhead the profiling has. I think you'll be the one living with the consequences, as I'm not on the ops team (yet? 🙃) so it's fair if you get to decide. 10% seems as good a percent as any. 👍🏻

tobiasmcnulty commented 2 months ago

Thanks for the review! This has been deployed.