search

djangocon / 2023.djangocon.us

🫐 The DjangoCon US 2023 conference website
https://2023.djangocon.us
Other
16 stars 49 forks source link

Support rendering pages without the nav and footer for iframes. #164

Closed tim-schilling closed 1 year ago

tim-schilling commented 1 year ago

LoudSwarm wants to have links to various types of content that exists on our site already. Rather than duplicating and dealing with stale data, this allows our site to be more easily used in an iframe.

This relies on JavaScript to detect that we're in an iframe, then remove the bulky nav and footer elements. This means that if a user has JavaScript disabled (they're going to have a tough time on LoudSwarm) they would still see the header and footer. Additionally, if they are using a slower machine, the header and footer would remain visible for a noticeable amount of time. But again, they're probably going to have a bad time on the LoudSwarm platform.

jefftriplett commented 1 year ago

@tim-schilling would you mind attaching a photo so we can see what this is doing?

tim-schilling commented 1 year ago

Good call. I should have thought of that.

Current header

Screen Shot 2023-08-07 at 8 31 47 PM

Header in an iframe

Screen Shot 2023-08-07 at 8 33 25 PM

Current footer

Screen Shot 2023-08-07 at 8 32 30 PM

Footer in an iframe

Screen Shot 2023-08-07 at 8 32 37 PM
jefftriplett commented 1 year ago

That looks good to me. Does it mesh well with LoudSwarm? Assuming I'm understanding the scope here. As long as an iframe in an iframe doesn't break anything, this seems good to me.

Ping me if you need me to build out any speaker or talk pages as static HTML pages. It's not a big lift to do, but probably not as straight forward as anyone would like.

tim-schilling commented 1 year ago

I haven't been able to test with Loudswarm yet. I'll ask Laura in our next meeting. And sounds good regarding the speakers page.