search

djangocon / 2023.djangocon.us

🫐 The DjangoCon US 2023 conference website
https://2023.djangocon.us
Other
16 stars 49 forks source link

Hover on social media icons isn't consistent #218

Open tim-schilling opened 10 months ago

tim-schilling commented 10 months ago

The hover style for social media icons either changes the color to light blue (twitter), doesn't change the color (mastodon) or changes it to white (website). These should all act the same and preferably change the color to either our design's secondary color, or be made to match the twitter icon's style.

This issue is visible on https://2023.djangocon.us/organizers/

Neel-07 commented 10 months ago

Hello, I am interested in working on this issue. I have some experience with CSS and I think I can make the social media icons change color on hover. I have already forked the repository and cloned it to my local machine. Can you please assign this issue to me? Thank you for your consideration. 😊

tim-schilling commented 10 months ago

Done deal! Thank you @Neel-07

Neel-07 commented 10 months ago

Hello @tim-schilling , I have solved the issue of the social media icons not having a consistent hover effect. I have also tested the solution on my local server and it works fine. Here is the message and the video that show my solution:

https://github.com/djangocon/2023.djangocon.us/assets/112561276/05b855df-ed89-449e-95e8-0029f9644f17

Please let me know what you think of my solution and if you have any suggestions for improvement. I would like to create a pull request for this issue and contribute to your project. Thank you for giving me the opportunity to contribute to your project. 😊

tim-schilling commented 10 months ago

@Neel-07 that looks great from a user perspective! Please open a PR. Thank you

Neel-07 commented 10 months ago

Hello @tim-schilling, I have created a pull request for the issue of the social media icons not having a consistent hover effect. I hope you will review my changes and merge them soon. The link to the pull request is provided (https://github.com/djangocon/2023.djangocon.us/pull/219) [here].

I would also like to add my name to the contributors list and be recognized for my contribution. Can I add my name to the contributors list, as I think it would be a recognition of my efforts and a motivation for me to continue contributing. I understand that this is not a trivial request, and I respect your decision either way. I just wanted to express my interest and ask for your permission.? Thank you for your cooperation. 😊