search

djangocon / 2024.djangocon.eu

MIT License
12 stars 13 forks source link

Fixed charts container width #45

Closed sakhawy closed 6 months ago

sakhawy commented 6 months ago

Related issue #44

Darkbeast-glitch commented 6 months ago

Cool @sakhawy , buh i see that you expanded the col to 12 - let me explain something to you image

the charts are three, and each of them has a span of 4 , the one you changed was for the first chart, so meaning the charts will look like this image

so yes, it's supposed to be 4 for each of the charts and not 12

kindly check if i am wrong before it's being merged

sakhawy commented 6 months ago

Hi @Darkbeast-glitch! Thanks for taking a look! I checked again and it looks like the rest of the page -including the other charts and page content after the first chart- is mistakingly nested inside that first column(?) That's why the lazy fix of changing the class from col-md-4 to col-md-12 worked I think. image (The yellow underline is highlighted by a popular VSCode extension called "Highlight Matching Tags".)

I did a quick count of opened div tags vs closed ones and looks like there are 2 missing closing </div>s:

$ grep -o "<div" schedule_talx.html | wc -l
13
$ grep -o "</div" schedule_talx.html | wc -l
11
Darkbeast-glitch commented 6 months ago

Thank you soo much @sakhawy for the help kindly check the website again for the chart

sakhawy commented 6 months ago

Oh! The chart got removed I see. The other ones look good! Thanks, I'm closing this PR! Should I close the other issue as well since that chart isn't there anymore (#46)?

Darkbeast-glitch commented 6 months ago

Oh! The chart got removed I see. The other ones look good! Thanks, I'm closing this PR! Should I close the other issue as well since that chart isn't there anymore (#46)?

yes sir, thank you very much for your help sir