search

djangocon / 2024.djangocon.us

🫐 The DjangoCon US 2024 conference website
https://2024.djangocon.us
Other
1 stars 12 forks source link

GitHub actions failing for people who don't have write access #9

Open drewbrew opened 2 months ago

drewbrew commented 2 months ago

See the runs here: https://github.com/djangocon/2024.djangocon.us/pull/7

drewbrew commented 2 months ago

we don't actually want deploying to GH pages to happen on every PR, right? https://github.com/djangocon/2024.djangocon.us/commit/8e4d55ecd169556a5ebc6c1f440c1d94e8c52ced#diff-e053be5b21a057e8d9e29f82426606cb8348a8b6001c522ef7d450c54018291aR7

mtrythall commented 2 months ago

@drewbrew Probably not. I set it up this way when I was rapidly prototyping.

What would you like to see? Build only on push to gh-pages?

drewbrew commented 2 months ago

Maybe build on push to check for errors, only deploy on main?

jefftriplett commented 2 months ago

This deploy on PR is fixed.

I re-opened this so we don't lose what should happen with a PR. Maybe it should build so we see errors or some a linter?

drewbrew commented 2 months ago

Yeah, if there's a lint option, I'm all for it