search

djangoflow / django-df-auth

Opinionated Django REST auth endpoints for JWT authentication and social accounts
MIT License
10 stars 19 forks source link

connect social account #10

Closed eugen1j closed 2 years ago

eugen1j commented 2 years ago

We can use SocialTokenViewSet for the authenticated user and connect the Social account to this user.

ayushin commented 2 years ago

Great solution code wise, however I am not sure if such implied functionality is a good thing?

I am thinking about some possible edge cases where you may be signed out or otherwise signed in and if you could get an unexpected result.

Perhaps an explicit connect method with respective permissions and same functionality as you've created would be cleaner?

Just thinking aloud.

But then again, maybe that can't happen.

@ziyapx what do you think?

ayushin commented 2 years ago

Anyway we can merge this and create an explicit connect method too.