Support social auth with twitter and other oauth providers that require multiple fields

djangoflow / django-df-auth

Opinionated Django REST auth endpoints for JWT authentication and social accounts

MIT License

10 stars 19 forks source link

Closed ayushin closed 1 year ago

ayushin commented 1 year ago

Problem: twitter (and some other providers) requires frontend to pass two fields, existing serialiser supports only access_token

[ ] Investigated needed changes, potentially:
[ ] Update SocialToken serialiser to include an extra field next to access_token
[ ] Update do_auth method to take extra / other arguments to allow for multi-arg (token/secret) server-side auth
[ ] Create tests

Also please see my comment below.

ayushin commented 1 year ago

In order for the PR to be merged:

make sure you create as little code as possible keep it DRY
think very hard how to name the fields/methods/variables
think of a generic solution, i.e. so that we can support other backends with the same serialiser without changing the API (this is related to proper fields naming)

ayushin commented 1 year ago

twitter requires frontend to pass two fields, existing serialiser supports only access_token