Adding filter and search functionality for messages list API (closes #4)

djangoflow / django-df-chat

Djangoflow in-app chat server using django-channels

MIT License

0 stars 16 forks source link

Adding filter and search functionality for messages list API (closes #4) #19

Closed pesfahanian closed 1 year ago

pesfahanian commented 1 year ago

Added all the requirements in the issue description. Code style is kept as same and as untouched as possible. Every new thing has tests and docstrings/comments. All tests pass.

pesfahanian commented 1 year ago

Recent changes to the tests break the following tests:

TestChat.test_auth
TestChat.test_chat_multiple_rooms
TestChat.test_chat_single_room

The problem is with the new BaseTestUtilsMixin.async_create_user method.

Awaiting further instructions to fix the tests.

pesfahanian commented 1 year ago

Please make sure to install pre-commit hooks: https://pre-commit.com/

Done! Also added its requirement to requirements.txt.

pesfahanian commented 1 year ago

Hello @pesfahanian, thank you for your work on the PR. Could you please address all the comments before requesting a re-review? This will help ensure that the review process is as efficient as possible. Thank you for your understanding.

All the comments have been addressed.